Deprecate the ranking pages#6347
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request deprecates and removes the ranking pages feature from the application. The changes involve a comprehensive cleanup of the codebase, including the removal of backend route registrations, API functions, frontend React components, CSS styles, and HTML templates. Additionally, references to these pages were stripped from existing UI templates, and the webpack build configuration was updated to reflect these removals. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request deprecates and completely removes the legacy place ranking feature, including its routes, templates, stylesheets, frontend components, and associated backend API endpoints. The feedback identifies opportunities to clean up remaining dead code, specifically pointing out unused imports in server/routes/shared_api/place.py and unused ranking_url macro definitions in both the custom and default place_landing.html templates.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| </a> | ||
| </li> | ||
| </ul> | ||
| </div> |
There was a problem hiding this comment.
Since the Rankings section has been completely removed from this template, the ranking_url macro defined at lines 26-28 is now unused. Additionally, because the ranking blueprint has been deprecated and removed, any future evaluation of this macro would fail as ranking.ranking is no longer a registered endpoint. Please remove the unused ranking_url macro definition from this file to clean up dead code.
| </a> | ||
| </li> | ||
| </ul> | ||
| </div> |
There was a problem hiding this comment.
Since the Rankings section has been completely removed from this template, the ranking_url macro defined at lines 26-28 is now unused. Additionally, because the ranking blueprint has been deprecated and removed, any future evaluation of this macro would fail as ranking.ranking is no longer a registered endpoint. Please remove the unused ranking_url macro definition from this file to clean up dead code.
| } | ||
| return Response(json.dumps(result), 200, mimetype='application/json') | ||
|
|
||
|
|
There was a problem hiding this comment.
With the removal of get_ranking_url and api_ranking, the imports url_for (line 24) and gettext (line 25) are no longer used anywhere in server/routes/shared_api/place.py. Please remove these unused imports to keep the codebase clean.
1 participant
No description provided.