Skip to content

Automated Integration Test Goldens Update from CI#6361

Open
datacommons-robot-author wants to merge 1 commit into
masterfrom
nl-golden-update-d83c798a-aab8-460d-8932-109b5a2f3ff4
Open

Automated Integration Test Goldens Update from CI#6361
datacommons-robot-author wants to merge 1 commit into
masterfrom
nl-golden-update-d83c798a-aab8-460d-8932-109b5a2f3ff4

Conversation

@datacommons-robot-author

Copy link
Copy Markdown
Collaborator

This pull request updates the golden files automatically via Cloud Build. Please review the changes carefully. Cloud Build Log

@datacommons-robot-author datacommons-robot-author requested review from a team and juliawu and removed request for a team June 11, 2026 18:21
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request contains automated updates to integration test golden files generated by the CI pipeline. These changes ensure that the test expectations remain aligned with the current output of the detection API, primarily involving minor adjustments to numerical precision in score values.

Highlights

  • Automated Golden File Updates: Updated various integration test golden files to reflect recent changes in detection API outputs.
  • Precision Adjustment: Standardized numerical values in JSON configuration and debug files to consistent decimal precision.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates integration test data by removing a classification entry from chart_config.json for the stateswithhighestphds test, and rounding cosine scores to four decimal places in several debug_info.json files across multiple multi-variable detection API tests. No review comments were provided, and I have no additional feedback to offer.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines -4 to -13
{
"quantity": {
"idx": 0,
"qval": {
"cmp": "GE",
"val": 2.2250738585072014e-308
}
},
"type": 3
},

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shixiao-coder To confirm, should this entry be removed? This seems to be a flakey test. I'm not sure which direction (with this entry included in goldens or excluded from goldens) results in less flakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants