Skip to content

Pets get a device named for them, not person_<slug> - #43

Merged
davidcoulson merged 3 commits into
mainfrom
fix/pet-devices
Oct 17, 2026
Merged

davidcoulson merged 3 commits into
mainfrom
fix/pet-devices

Conversation

@davidcoulson

Copy link
Copy Markdown
Owner

A pet is a person.* entity to Home Assistant, so its Sextant device showed up as person_leela (Sextant).

  • Person/pet devices are named from the friendly name: Leela (Sextant).
  • Pets (owners whose things are all cat/dog/paw tags, the rule room occupancy already used, now persons.pet_persons) get model Sextant pet (BLE Positioning); people get Sextant person (BLE Positioning).
  • Sensors and device tracker now give the shared device the same name and model.
  • Device identifiers and entity ids are unchanged, so automations and dashboards keep working; HA renames the existing device on reload unless the user renamed it.

Tests: new test_persons case; suite 730 passed, 1 pre-existing failure (test_truth.py gc-tracking test, fails on main too).

🤖 Generated with Claude Code

A pet is a person.* entity to Home Assistant, so Sextant grouped its
sensors under a device named from the internal key ("person_leela
(Sextant)"). The device is now named from the friendly name ("Leela
(Sextant)") and a pet's - an owner whose things are all cat, dog or paw
tags - carries a pet's model. Sensors and tracker agree on both.
Identifiers and entity ids are unchanged, so nothing downstream breaks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-17T09:10:09.914190Z ed992a5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Repository: davidcoulson/sextant/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5b89cb17-2e8e-4282-94cf-90e9c404a19c
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@davidcoulson
davidcoulson merged commit ad0ae7a into main Oct 17, 2026
13 checks passed
@davidcoulson

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Pull request is closed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant