fix: Mismatch in fetched versions and tests issues on 24.14-24.15 (openssl related)#24
Merged
Conversation
cmd_add matched the first commit whose message contained the requested version, including FROM-side matches in "X -> Y" bumps, and never verified the rev actually shipped that version. This caused mislabeled entries (e.g. 24.13/24.14 keys pinning revs that built 24.14.0/24.15.0). cmd_add now reuses extract_version to take the TO-side, and add_version verifies pkgs/development/web/nodejs/v<major>.nix at the resolved rev sets version = "<major.minor>.x" before writing the entry. This guards cmd_discover too.
…6.0-26.2) Same FROM-side bump-message mismatch as the 24.13/24.14 bug: each of these keys pinned the rev landing the *next* minor (e.g. 25.7 pinned the "25.6.1 -> 25.7.0" commit, which ships 25.7.0, not 25.6.x). 25.8 and 26.2 were additionally exact duplicates of 25.9 and 26.3. Re-pinned each key to a rev verified (via v<major>.nix at that rev) to actually ship <key>.x: 22.0 -> nodejs_22 init at 22.0.0 25.5 -> 25.4.0 -> 25.5.0 25.6 -> latest 25.6.1 25.7 -> 25.6.1 -> 25.7.0 25.8 -> latest 25.8.2 26.0 -> 26.0.0-rc.2 -> 26.0.0 26.1 -> 26.0.0 -> 26.1.0 26.2 -> 26.1.0 -> 26.2.0 All chosen revs predate the openssl 3.6.1->3.6.2 bump (2026-04-09), so none hit the TLS test failures fixed for 24.x/25.x. Known follow-up: 26.2/26.3 (rev ships 26.3.0) has no equivalent nodejs_26 openssl-tls test fix in nixpkgs yet - may hit the same test-tls-alert-handling/test-tls-junk-server failures on next build.
davidnbr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-pinned each key to a rev verified (via v.nix at that rev)
to actually ship .x:
22.0 -> nodejs_22 init at 22.0.0
25.5 -> 25.4.0 -> 25.5.0
25.6 -> latest 25.6.1
25.7 -> 25.6.1 -> 25.7.0
25.8 -> latest 25.8.2
26.0 -> 26.0.0-rc.2 -> 26.0.0
26.1 -> 26.0.0 -> 26.1.0
26.2 -> 26.1.0 -> 26.2.0
All chosen revs predate the openssl 3.6.1->3.6.2 bump (2026-04-09),
so none hit the TLS test failures fixed for 24.x/25.x.
Known follow-up: 26.2/26.3 (rev ships 26.3.0) has no equivalent
nodejs_26 openssl-tls test fix in nixpkgs yet - may hit the same
test-tls-alert-handling/test-tls-junk-server failures on next build.