deadpool-sqlite: add OpenFlags config for read-only connections - #500
Open
ChrisJr404 wants to merge 2 commits into
Open
deadpool-sqlite: add OpenFlags config for read-only connections#500ChrisJr404 wants to merge 2 commits into
ChrisJr404 wants to merge 2 commits into
Conversation
bikeshedder
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #446.
deadpool-sqlitealways opened connections withrusqlite::Connection::open, so there was no way to get a read-only connection like the issue asks for. This adds an optionalflagsfield toConfigplus a small serde-friendlyOpenFlagstype, and opens withopen_with_flagswhen it is set. WhenflagsisNonethe behaviour is unchanged.I followed the same shape
deadpool-libsqlalready uses for itsOpenFlagsso the two crates stay consistent and it keeps working with theconfigcrate. Added a test that opens a read-only pool and checks reads succeed while writes are rejected.