fix(deps): bump @deco-cx/warp-node to 0.3.23 to fix link-tunnel HMR#3455
Merged
Conversation
0.3.20 passes an `http:`-scheme URL to `new WebSocket(...)` when forwarding upgrades in `handlers.client.ts`. Node's undici silently rewrites it to `ws:`, but Bun keeps the scheme and the handshake fails immediately — so every WebSocket through the link tunnel (Vite HMR, Next.js webpack-hmr/Turbopack HMR) dies before connecting when the link daemon runs under Bun, which it always does via `bunx decocms link`. Upstream fix: deco-cx/warp-node#2, released in 0.3.22/0.3.23. Issue: deco-cx/warp-node#1. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
🧪 BenchmarkShould we run the Virtual MCP strategy benchmark for this PR? React with 👍 to run the benchmark.
Benchmark will run on the next push after you react. |
Contributor
Release OptionsSuggested: Patch ( React with an emoji to override the release type:
Current version:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this contribution about?
Bumps
@deco-cx/warp-nodefrom^0.3.20→^0.3.23to fix dev-server HMR through the link daemon's Warp tunnel.0.3.20 calls
new WebSocket(new URL(reqPath, "http://127.0.0.1:<daemonPort>"))inhandlers.client.tswithout coercing the scheme. Node's undici silently rewriteshttp:→ws:, so this went unnoticed in Node-hosted callers — but Bun keeps the scheme as-is and the handshake fails immediately. Sincebunx decocms linkalways runs the link daemon under Bun, every WebSocket forwarded through the tunnel (Vite HMR, Next.js webpack-hmr/Turbopack HMR) died before the upgrade, so file edits in linked sandboxes never hot-reloaded. Upstream fix: deco-cx/warp-node#2, shipped in 0.3.22/0.3.23 (issue: deco-cx/warp-node#1).How to Test
bun install(no-op if you're already on this branch).bunx decocms link@latest(clear bunx cache if needed so the new dep resolves)..tsxfile, and confirm the browser hot-reloads instead of requiring a full refresh.Migration Notes
None. Pure dependency bump.
Review Checklist
node_modules/@deco-cx/warp-node@0.3.23/dist/handlers.client.js)Summary by cubic
Bump
@deco-cx/warp-nodeto 0.3.23 to restore HMR over the link tunnel when the link daemon runs under Bun. Fixes failed WebSocket upgrades that broke Vite/Next.js hot reload in Studio previews.ws:for tunneled WebSocket handshakes, so Bun no longer drops the connection.Written for commit fd7f0d0. Summary will update on new commits. Review in cubic