refactor(file-storage): remove unused orgFsChangeSubject export#5172
Merged
Conversation
orgFsChangeSubjects (plural) is the only one org-fs.ts calls; the singular orgFsChangeSubject had zero callers outside its own test.
pedrofrxncx
enabled auto-merge (squash)
July 24, 2026 14:02
decocms Bot
pushed a commit
that referenced
this pull request
Jul 24, 2026
PR: #5172 refactor(file-storage): remove unused orgFsChangeSubject export Bump type: patch - decocms (apps/api/package.json): 4.122.5 -> 4.122.6 Deploy-Scope: server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Net code reduction found while auditing
apps/api/src/file-storage/(org-fs filesystem abstraction).org-fs-notify.tsexports bothorgFsChangeSubject(singular) andorgFsChangeSubjects(plural, added in today's #5120 apps/mesh -> apps/api split, which also introduced the dual studio/mesh subject-alias for rolling upgrades).rgacross the repo (.ts/.tsxand non-TS sources) shows the singular function has zero callers outside its own test file — the one real caller,apps/api/src/api/routes/org-fs.ts, only ever imports the pluralorgFsChangeSubjects. This PR deletes the dead singular export and the test cases that only existed to cover it.Net delta: -23 / +7 lines. Behavior-preserving: the plural function and
notifyOrgFsChange(its only consumer) are untouched; only the unused function and its now-redundant assertions are removed.Reviewer command:
bun test apps/api/src/file-storage/org-fs-notify.test.tsLocally ran:
bun run fmt,cd apps/api && bunx tsc --noEmit(clean), and the targeted test file above (3 pass). Full CI validates the rest.Summary by cubic
Removed the unused
orgFsChangeSubjectexport and its tests to standardize onorgFsChangeSubjects. No behavior change;notifyOrgFsChangecontinues to use the plural subjects and invalid tokens still yield an empty list.Written for commit 0468b52. Summary will update on new commits.