Follow a call made inside an imported module - #884
Merged
Conversation
A function reached across a module boundary can call its own module's functions, and those have no index in the program being compiled either. The lowering only looked for an import, so `markdown.deed` was refused at `slice`, which `std/string`'s own `replace` calls and nothing imports. Same path as an import: the callee is lowered from the module being read, as it is reached, into the same program. Nothing here is on the path of a program that imports nothing. Twenty-eight of thirty-four. Part of #877.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #882. A function reached across a module boundary can call its own module's functions, and those have no index in the program being compiled either. The lowering only looked for an import, so
markdown.deedgot refused atslice, whichstd/string's ownreplacecalls and nothing imports.Same path as an import: the callee is lowered from the module being read, as it is reached, into the same program. Nothing here is on the path of a program that imports nothing.
The agreement test grew a function in the library that calls another one in the same library, since that was the case that was missing.
Twenty-eight of thirty-four. Part of #877.
Written with AI assistance.