Skip to content

Fix NVRTC compilation for HyperConnection kernels #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nya-a-cat wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix NVRTC compilation for HyperConnection kernels #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions deep_gemm/include/deep_gemm/impls/sm100_tf32_hc_prenorm_gemm.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wunknown-attributes"

#include <cuda_device_runtime_api.h>

@ds-review-bot ds-review-bot Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 warning: Validation/scope. The original failure was NVRTC-specific, but the fix is unconditional and is now compiled by the NVCC/clang host/prebuilt and the non-NVRTC device paths as well. The PR only ran NVRTC compile-only regressions and git diff --check, so a green NVRTC compile does not prove those other compiler configurations still compile/link, nor that device behavior is unchanged. A full build (NVCC/clang/prebuilt) and, if possible, a GPU run should be done before merge.

🤖 v4


#include <cutlass/arch/barrier.h>

#include <deep_gemm/common/cute_tie.cuh>
Expand Down
2 changes: 2 additions & 0 deletions deep_gemm/include/deep_gemm/impls/sm90_tf32_hc_prenorm_gemm.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wunknown-attributes"

#include <cuda_device_runtime_api.h>

@ds-review-bot ds-review-bot Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 warning: Unconditional, outside-guard placement (same at sm100_tf32_hc_prenorm_gemm.cuh:5). The only reference is at sm90:122 / sm100:139 inside #if (defined(__CUDA_ARCH__) and (__CUDA_ARCH__ >= ...)) ... or defined(__CLION_IDE__), and NVCC already provides the decl only on the device pass. This header is device-runtime-only and is also pulled into host/prebuilt/clang-cuda compilation of the same .cuh. Recommend moving/guarding it consistently (e.g. behind __CUDACC_RTC__/__CUDA_ARCH__, or use a minimal extern "C" cudaError_t cudaGridDependencySynchronize(void); prototype guarded by __CUDACC_RTC__) to avoid fragile/version-dependent effects on the other build paths.

🤖 v4


#include <cutlass/arch/barrier.h>
#include <cutlass/arch/reg_reconfig.h>

Expand Down