Skip to content

feat: add IBM Db2 Vector Store (ibm-haystack)#3458

Closed
priyanshu-krishnan1 wants to merge 8 commits into
deepset-ai:mainfrom
GeetikaChughIBM:ibm-db2-vs
Closed

feat: add IBM Db2 Vector Store (ibm-haystack)#3458
priyanshu-krishnan1 wants to merge 8 commits into
deepset-ai:mainfrom
GeetikaChughIBM:ibm-db2-vs

Conversation

@priyanshu-krishnan1

Copy link
Copy Markdown

Related Issues

  • fixes #issue-number

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

@priyanshu-krishnan1 priyanshu-krishnan1 requested a review from a team as a code owner June 17, 2026 01:09
@priyanshu-krishnan1 priyanshu-krishnan1 requested review from sjrl and removed request for a team June 17, 2026 01:09
@CLAassistant

CLAassistant commented Jun 17, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ priyanshu-krishnan1
❌ Dhruv Chaturvedi


Dhruv Chaturvedi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions Bot added the type:documentation Improvements or additions to documentation label Jun 17, 2026
@socket-security

socket-security Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedpypi/​ibm-db@​3.2.984100100100100

View full report

@sjrl sjrl closed this Jun 17, 2026
@sjrl sjrl reopened this Jun 17, 2026
@sjrl

sjrl commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Hey @priyanshu-krishnan1 thanks for the opening PR! Apologies for closing that was a misclick. Its looking good so far, I have some high-level comments:

@sjrl sjrl self-assigned this Jun 17, 2026
@priyanshu-krishnan1

priyanshu-krishnan1 commented Jun 17, 2026

Copy link
Copy Markdown
Author

Hi @sjrl, Thank you for the detailed review and feedback.
I will address all the points in next commits on this PR:

  • Currently working on retriever and will add retriever logic into scaffolded folder of component/retrievers.
  • Refactor the document store tests to use the shared mixin test approach, following the PGVector integration as a reference.
  • Rename the integration to ibm-db-haystack and update the module structure from ibm to ibm_db as recommendations from @julian-risch
  • Add the appropriate entry to .github/labeler.yml in alphabetical order.
  • Add the required CI workflow files based on the existing document store integrations.
  • Update CI_coverage_comment.yml accordingly.

Thanks again for the guidance.

Removed redundant integration:ibm-db entry and consolidated file patterns.
@sjrl

sjrl commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Hi @priyanshu-krishnan1, just flagging this early so it can be addressed before the PR progresses further.

One of the commits in this PR appears not to be linked to a GitHub user, which is causing the CLA checks to fail:

6ddfa5f

The failing CLA check is here:

#3458 (comment)

It looks like this commit may belong to Dhruv Chaturvedi. Could you please check with them and ask them to sign the CLA as well? Alternatively, if that commit is not needed or was included by mistake, please remove it from the PR history so the CLA check can pass.

@priyanshu-krishnan1

Copy link
Copy Markdown
Author

Hi @sjrl, we have completed the development for Phase 1 of the IBM Db2 Vector Store. The implementation is now ready for your review. We'd appreciate your feedback and any suggestions for improvements.

@sjrl

sjrl commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Hey @priyanshu-krishnan1 great to hear! I should be able to give this another review soon. In the mean time could you look at this comment I left #3458 (comment)

It has to do with resolving the CLA agreement check.

@sjrl

sjrl commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Hi @priyanshu-krishnan1 , the last force-push didn't fix the CLA issue and pulled in several unrelated commits (dependabot, a Chroma fix, a changelog bump), which is what spammed the coverage-report comments. The CLA is still failing because of commit 6ddfa5f ("Add IBM integration label and config"), which is authored by Dhruv Chaturvedi under an email that isn't linked to a GitHub account.

The branch history is tangled from old main merges, so the simplest path forward is to start clean: branch off the latest main, copy over just your integrations/ibm_db/ work plus the config changes (labeler, CI coverage, workflow, README), commit it as a single commit authored by you, and open a fresh PR. That drops all the unrelated commits and the bad-author commit in one go, and the CLA check should pass.

Let me know if you have any questions!

@priyanshu-krishnan1

Copy link
Copy Markdown
Author

Hi @sjrl, as per your recommendation, we've created a new PR: #3518.
Please review the new PR and share your feedback or any suggestions for improvement.
Thanks!

@priyanshu-krishnan1

Copy link
Copy Markdown
Author

closing this PR, development have been moved to this new PR as per recommendation
#3518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic:CI type:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants