feat: add IBM Db2 Vector Store (ibm-haystack)#3458
Conversation
|
Dhruv Chaturvedi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
6412c10 to
e831354
Compare
|
Hey @priyanshu-krishnan1 thanks for the opening PR! Apologies for closing that was a misclick. Its looking good so far, I have some high-level comments:
|
|
Hi @sjrl, Thank you for the detailed review and feedback.
Thanks again for the guidance. |
af3a4d0 to
3f7df31
Compare
Removed redundant integration:ibm-db entry and consolidated file patterns.
|
Hi @priyanshu-krishnan1, just flagging this early so it can be addressed before the PR progresses further. One of the commits in this PR appears not to be linked to a GitHub user, which is causing the CLA checks to fail: The failing CLA check is here: It looks like this commit may belong to Dhruv Chaturvedi. Could you please check with them and ask them to sign the CLA as well? Alternatively, if that commit is not needed or was included by mistake, please remove it from the PR history so the CLA check can pass. |
* Added ibm db2 retriever
|
Hi @sjrl, we have completed the development for Phase 1 of the IBM Db2 Vector Store. The implementation is now ready for your review. We'd appreciate your feedback and any suggestions for improvements. |
|
Hey @priyanshu-krishnan1 great to hear! I should be able to give this another review soon. In the mean time could you look at this comment I left #3458 (comment) It has to do with resolving the CLA agreement check. |
202206d to
67acd0f
Compare
|
Hi @priyanshu-krishnan1 , the last force-push didn't fix the CLA issue and pulled in several unrelated commits (dependabot, a Chroma fix, a changelog bump), which is what spammed the coverage-report comments. The CLA is still failing because of commit 6ddfa5f ("Add IBM integration label and config"), which is authored by Dhruv Chaturvedi under an email that isn't linked to a GitHub account. The branch history is tangled from old Let me know if you have any questions! |
|
closing this PR, development have been moved to this new PR as per recommendation |
Related Issues
Proposed Changes:
How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.