Skip to content

ldap function fix to read special characters from credentials when encrypted #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abhishek-sa1 merged 9 commits into from
Aug 7, 2026
Merged

ldap function fix to read special characters from credentials when encrypted #594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e9219f6
modified the report format
Rohith-Ravut Jul 30, 2026
65b3f34
slurm gpu multi-node handleing
Rohith-Ravut Jul 31, 2026
f8ec36e
modified report functions to capture the playbook failures as well
Rohith-Ravut Aug 3, 2026
9f4a808
Merge branch 'dell:automation-v2.2.0.0' into automation-v2.2.0.0
Rohith-Ravut Aug 4, 2026
66e821a
Update run_molecule.sh
Rohith-Ravut Aug 4, 2026
ec3dc86
Update __init__.py
Rohith-Ravut Aug 4, 2026
32958d3
Update report_func.py
Rohith-Ravut Aug 4, 2026
7241392
Update repository.py
Rohith-Ravut Aug 6, 2026
fa10a63
Update ldap_func.py
Rohith-Ravut Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion automation_library/checks/functions/repository.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ def download_omnia_sh() -> Dict:
}

# Try tag URL
rc, _, _ = run_command(["curl", "-f", "-o", f"{clone_path}/omnia.sh", tag_url], timeout=60)
rc, _, _ = run_command(["curl", "-f", "-o", f"{clone_path}/omnia.sh", tag_url], timeout=300)
if rc == 0:
_log(f"omnia.sh downloaded from tag: {omnia_branch}", "OK")
return {
Expand Down
12 changes: 9 additions & 3 deletions automation_library/provision/functions/ldap_func.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,8 +495,10 @@ def _verify_ldap_user_login(host, run_func) -> Dict[str, Any]:

user_result = {"user": ldap_user, "success": False, "message": ""}

# Properly escape password for shell - use double quotes and escape special chars
escaped_password = ldap_password.replace('\\', '\\\\').replace('"', '\\"').replace('$', '\\$').replace('`', '\\`')
ssh_cmd = (
f"sshpass -p '{ldap_password}' ssh -o StrictHostKeyChecking=no "
f'sshpass -p "{escaped_password}" ssh -o StrictHostKeyChecking=no '
f"-o UserKnownHostsFile=/dev/null -o ConnectTimeout=10 "
f"{ldap_user}@{admin_ip} 'echo LOGIN_SUCCESS' 2>&1"
)
Expand Down Expand Up @@ -600,8 +602,10 @@ def verify_pam_slurm_adopt(host) -> Dict[str, Any]:
}

# SSH login using sshpass - should be blocked by PAM
# Properly escape password for shell - use double quotes and escape special chars
escaped_password = ldap_password.replace('\\', '\\\\').replace('"', '\\"').replace('$', '\\$').replace('`', '\\`')
ssh_cmd = (
f"sshpass -p '{ldap_password}' ssh -o StrictHostKeyChecking=no "
f'sshpass -p "{escaped_password}" ssh -o StrictHostKeyChecking=no '
f"-o UserKnownHostsFile=/dev/null -o ConnectTimeout=10 "
f"{ldap_user}@{admin_ip} 'echo LOGIN_SUCCESS' 2>&1"
)
Expand Down Expand Up @@ -864,8 +868,10 @@ def verify_pam_slurm_adopt_session_termination(host) -> Dict[str, Any]:
details_lines.append(f" ✓ Job {job_id}: RUNNING on {actual_compute_hostname} (IP: {actual_compute_ip})")

# Login to the actual compute node as ldapuser during active job
# Properly escape password for shell - use double quotes and escape special chars
escaped_password = ldap_password.replace('\\', '\\\\').replace('"', '\\"').replace('$', '\\$').replace('`', '\\`')
login_cmd = (
f"sshpass -p '{ldap_password}' ssh {SSH_OPTS} "
f'sshpass -p "{escaped_password}" ssh {SSH_OPTS} '
f"{ldap_user}@{actual_compute_ip} 'echo LOGIN_SUCCESS' 2>&1"
)
cmd = run_on_oim(host, login_cmd)
Expand Down
Loading