Skip to content

DLPX-88427 Filter garbage stat names from estat metaslab-alloc output #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dbshah12 wants to merge 1 commit into from
Closed

DLPX-88427 Filter garbage stat names from estat metaslab-alloc output #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions telegraf/metaslab-alloc-stats.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
#!/bin/sh
#
# Wrapper around "estat metaslab-alloc -jm 10" that filters out metrics whose
# "name" tag contains garbage characters (DLPX-88427). A kernel bug causes
# estat to occasionally emit stat names containing raw memory bytes or C macro
# strings. Only names consisting of printable ASCII letters, digits, spaces,
# and common punctuation are passed through.
#
estat metaslab-alloc -jm 10 | grep -E '"name":"[A-Za-z0-9 ,_()/.-]+"'
5 changes: 3 additions & 2 deletions telegraf/telegraf.inputs.playbook
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,10 @@
]
json_string_fields = ["iops(/s)", "avg latency(us)", "stddev(us)", "throughput(k/s)", "microseconds"]

# Collect output from "estat metaslab-alloc -jm 10"
# Collect output from "estat metaslab-alloc -jm 10" via wrapper script.
# The wrapper filters out metrics with garbage "name" tags (DLPX-88427).
[[inputs.execd]]
command = ["estat", "metaslab-alloc", "-jm", "10"]
command = ["/etc/telegraf/metaslab-alloc-stats.sh"]
name_override = "estat_metaslab-alloc"
signal = "none"
restart_delay = "30s"
Expand Down
Loading