Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge/split operations could skip unreadable inputs, truncate large files or report success after incomplete writes. Settings saves could overwrite XML directly or remove the registry profile before its replacement was written. This change preserves existing data when an operation fails or is cancelled.
.bak; loading can recover a valid backup while protecting both files from automatic overwrites.GetAnyOperationsAbortedafter shell file operations so an aborted batch is not recorded as successful.The first commit isolates the locale change needed to run the regression suite under either English or Italian Windows settings. Production callers retain their existing system-locale formatting. The second commit contains the data-integrity changes, component tests, history entries and user documentation. Generated translations are left to the normal Crowdin workflow; new messages have an English fallback.
Validation on the proposed tree, based on current
master(62dc36c):it-ITsettings. This includes 36 added regressions.WriteFilecalls.it-ITanden-US(3/3 for the English run), preserving1,00 KBand1.00 KBrespectively.The negative tests cover existing/locked/read-only destinations, missing inputs, short transfers, unexpected EOF, simulated disk-full and flush failures, cancellation before publication, rollback ownership, denied registry access, abandoned transactions, malformed XML and backup recovery. Test execution was isolated in Windows Sandbox with networking and clipboard sharing disabled.
Limits: this does not merge conflicting settings from independent instances; sequential saves still use the last snapshot. Publishing multiple split parts is not a filesystem-wide transaction, so forced termination may leave complete parts or temporary files. Other architectures and sanitizer/Clang configurations remain subject to the repository's CI checks.