Skip to content

fix: correct timezone handling in datetime-based integration tests #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d-rk merged 1 commit into from
Jul 30, 2026
Merged

fix: correct timezone handling in datetime-based integration tests #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/consume/consume_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,8 @@ func TestConsumeFromTimestampIntegration(t *testing.T) {

// test --from-timestamp with --to-timestamp with formatted dates
kafkaCtl := testutil.CreateKafkaCtlCommand()
t1Formatted := time.UnixMilli(t1).Format("2006-01-02T15:04:05.000Z")
t2Formatted := time.UnixMilli(t2).Format("2006-01-02T15:04:05.000Z")
t1Formatted := time.UnixMilli(t1).UTC().Format("2006-01-02T15:04:05.000Z")
t2Formatted := time.UnixMilli(t2).UTC().Format("2006-01-02T15:04:05.000Z")
if _, err := kafkaCtl.Execute("consume", topicName, "--from-timestamp", t1Formatted, "--to-timestamp", t2Formatted); err != nil {
t.Fatalf("failed to execute command: %v", err)
}
Expand Down
2 changes: 1 addition & 1 deletion cmd/reset/reset-consumer-group-offset_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ func TestResetCGOToDatetimeIntegration(t *testing.T) {
time.Sleep(1 * time.Millisecond) // need to have messaged produced at different milliseconds to have reproducible test

t1 := time.Now()
t1Formatted := t1.Format("2006-01-02T15:04:05.000Z")
t1Formatted := t1.UTC().Format("2006-01-02T15:04:05.000Z")

testutil.ProduceMessage(t, topicName, "test-key", "c", 0, 2)
testutil.ProduceMessage(t, topicName, "test-key", "d", 0, 3)
Expand Down
Loading