fix(produce): report only successfully produced messages on failure - #342
Open
jakubdyszkiewicz wants to merge 1 commit into
Open
jakubdyszkiewicz wants to merge 1 commit into
jakubdyszkiewicz wants to merge 1 commit into
Conversation
The produce command incremented the message counter before sending, so a failed send was included in the count. On error the command printed 'N messages produced' with the failed message included, even though the message was rejected by the broker and never stored. Move the counter increment after a successful SendMessage so the count only includes produced messages. Add an integration test that produces a message larger than the broker's message.max.bytes and asserts '0 messages produced' on failure.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hey 👋
I noticed that when I violate broker policy (placed by my proxy) I get the following message
I reproduced it with producing a message that's too big.
It seems that the produce command incremented the message counter before sending, so a failed send was included in the count.
^ should I create issue first?
Type of change
Please delete options that are not relevant.
Documentation
No new docs. It's just a fix
## [Unreleased]section ofCHANGELOG.mdREADME.adocwas updatedREADME.adoc