Harden mainnet origin and alternative-origin validation - #762
Open
zeropath-ai[bot] wants to merge 2 commits into
Open
zeropath-ai[bot] wants to merge 2 commits into
zeropath-ai[bot] wants to merge 2 commits into
Conversation
Contributor
Author
|
✅ No security or compliance issues detected. Reviewed everything up to 8f2ee94. Security Overview
Detected Code Changes
|
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes correctly address both reported origin-validation vulnerabilities.
Pull request overview
Hardens Internet Identity origin validation against lookalike-domain attacks.
Changes:
- Requires exact or dot-delimited mainnet domain matches.
- Validates alternative origins against the target canister.
File summaries
| File | Description |
|---|---|
tools/ui/src/auth/auth.ts |
Secures mainnet detection and alternative-origin verification. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
insertLoginForm()now treats any hostname whose suffix matchesicp0.io,ic0.app, oricp.netas a trusted mainnet origin by usingwindow.location.hostname.endsWith(domain). That accepts attacker-controlled lookalike domains such asevilicp.net. Becausecheck_alternative_origin()only fetches/.well-known/ii-alternative-originsfrom the current origin and checks whether that origin lists itself, an attacker-controlled suffix-matching site can satisfy the check trivially, causing the code to auto-setderivationOrigintohttps://<canister-id>.<matched-domain>and use the production II provider. In practice, a phishing site hosted on a suffix-matching domain can make users authenticate via Internet Identity while the app receives a delegation scoped as the target canister origin, letting the attacker use the victim's identity against that canister. Trusted mainnet detection needs an origin boundary check (exact host or.-delimited subdomain) and the alternative-origin proof should be tied to the target canister origin, not self-asserted by the current page.