feat: [DSM-148] XNetAdvertHandler for XNetPayloadBuilderImpl - #11602
Conversation
|
✅ No security or compliance issues detected. Reviewed everything up to c25885c. Security OverviewDetected Code Changes
|
21f7bf3 to
828ebb1
Compare
828ebb1 to
d194f26
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):
-
Update
unreleased_changelog.md(if there are behavior changes, even if they are
non-breaking). -
Are there BREAKING changes?
-
Is a data migration needed?
-
Security review?
How to Satisfy This Automatic Review
-
Go to the bottom of the pull request page.
-
Look for where it says this bot is requesting changes.
-
Click the three dots to the right.
-
Select "Dismiss review".
-
In the text entry box, respond to each of the numbered items in the previous
section, declare one of the following:
-
Done.
-
$REASON_WHY_NO_NEED. E.g. for
unreleased_changelog.md, "No
canister behavior changes.", or for item 2, "Existing APIs
behave as before.".
Brief Guide to "Externally Visible" Changes
"Externally visible behavior change" is very often due to some NEW canister API.
Changes to EXISTING APIs are more likely to be "breaking".
If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.
If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.
Reference(s)
For a more comprehensive checklist, see here.
GOVERNANCE_CHECKLIST_REMINDER_DEDUP
|
✅ No security or compliance issues detected. Reviewed everything up to 098441b. Security OverviewDetected Code ChangesThe diff is too large to display a summary of code changes. |
|
✅ No security or compliance issues detected. Reviewed everything up to 098441b. Security OverviewDetected Code ChangesThe diff is too large to display a summary of code changes. |
|
✅ No security or compliance issues detected. Reviewed everything up to 098441b. Security OverviewDetected Code ChangesThe diff is too large to display a summary of code changes. |
Handles an advert — a certified, header-only stream slice pushed by a source subnet — by classifying it against our certified state first (`NothingNew`, answered with our own certified header) and then against the pool (§6). Only the two outcomes that act on the advert being genuine, `NothingNew` and `Actionable`, pay for a threshold-signature verification; the rest are dropped on the unverified claim alone, which can only understate what the peer holds. Every verified header is recorded in `peer_headers`: our only record of how far the peer has garbage collected its messages, hence of whether we still owe it an advert. Nothing calls this yet; the endpoint follows. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…ignature and DecodeError; improve unit tests.
…t and would need to be explicitly validated. Simply compare the headers' indices.
…; simplify record_peer_header() doc comment; improve make_advert() fixture documentation; drop mostly irrelevant unit test for classifying incomparable adverts.
…ning XNetAdvertError::DecodeError.
ded2539 to
c25885c
Compare
|
Sorry about the mess, bad rebase/merge/whatever. |
Bad rebase/merge. The PR does not touch any Governance code.
3 participants
Handles an advert — a certified, header-only stream slice pushed by a source subnet — by classifying it against our certified state first (
NothingNew, answered with our own certified header) and then against the pool. Only the two outcomes that act on the advert,NothingNewandActionable, require a threshold-signature verification; the rest are dropped on the unverified claim alone, which can only understate what the peer holds.Every verified header is recorded in
peer_headers: our only record of how far the peer has garbage collected its messages, hence of whether we still owe it an advert.Nothing calls this yet; the endpoint follows.