Repository navigation
refactor(p2p): avoid unnecessary nested locks in artifact serve & download - #11974
Draft
pierugo-dfinity wants to merge 1 commit into
Draft
pierugo-dfinity wants to merge 1 commit into
pierugo-dfinity wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified in the downloader/router separation and shared-pool locking refactor.
No open issues 🎉
What changed in this PR
This PR refactors peer-to-peer artifact downloading and serving to remove unnecessary nested pool locks while preserving the existing combined API.
Changes:
- Separates downloader creation from router construction and encapsulates shared-pool locking.
- Updates stripped-consensus handling to use the separate components.
- Adds router tests for serving stripped block proposals and returning no content for missing messages.
| File | Description |
|---|---|
rs/p2p/artifact_downloader/src/fetch_stripped_artifact/assembler.rs |
Removes redundant wrapper locking and adds serving tests. |
rs/p2p/artifact_downloader/src/fetch_artifact/download.rs |
Splits downloader and router construction and introduces a shared-pool adapter. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.