Repository navigation
chore(deps): update pocket-ic to 16.0.0 - #90
Merged
Merged
Conversation
pocket-ic 16.0.0 is a published crates.io release, so this switches off the dfinity/ic git pin and back onto the registry, the way v11.0.0 and v12.0.0 were released. The suffix-less package version is what selects that path: package.sh checks `package.version` against the pocket-ic dependency's source and requires the two to agree, then fetches the server binary from the dfinity/pocketic release matching the version instead of from a dfinity/ic release tag. No source changes were needed for 15 -> 16 — the launcher touches no API that changed. The scheduled update workflow only understands dfinity/ic release tags and always writes a git rev, so it will move the pin back to a dated prerelease on its next run; that matches what happened after v12.0.0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates icp-cli-network-launcher to track PocketIC 16.0.0 via the published crates.io release (instead of a git pin), aligning the launcher’s versioning and lockfile with the registry-sourced dependency so releases can be built from a stable, reproducible source.
Changes:
- Bump crate version to
16.0.0. - Switch
pocket-icdependency from adfinity/icgit revision topocket-ic16.0.0on crates.io. - Regenerate
Cargo.lockto reflect the newpocket-icsource and updated transitive dependencies.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Cargo.toml | Bumps package version and switches pocket-ic to the crates.io 16.0.0 release. |
| Cargo.lock | Updates lock entries for pocket-ic (now registry-sourced) and related transitive dependency versions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
package.sh fetches the pocket-ic server binary from a URL derived from package.version, while the client crate comes from the resolved dependency graph. Nothing tied the two together: `cargo build --release` re-resolves freely, so a re-resolution that moved the client within its caret range -- `cargo update` being the obvious way -- would pair a newer client with the older server binary package.version still points at. That pairing fails, and only in that direction: the client checks the server's --version against >=MIN_SERVER_VERSION,<MAX_SERVER_VERSION, where MIN is the client crate's own version. A 16.0.0 client accepts a 16.1.0 server; a 16.1.0 client rejects a 16.0.0 one. --locked makes any such drift fail the release build instead of shipping a mismatched pair. ci.yml already tests with --locked; this closes the same gap on the path that actually builds what is released. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
raymondk
approved these changes
Sep 1, 2026
lwshang
added a commit
that referenced
this pull request
Sep 14, 2026
The version bump to 16.0.0-2026-09-03-04-41 landed without the matching dependency change: #90 moved pocket-ic from a git rev to the crates.io release, so update-pocket-ic.sh's `rev = "..."` substitution no longer matched and silently left the dependency at the published 16.0.0. That state does not release — package.sh rejects a dated package version whose pocket-ic dependency is not a git source. Point pocket-ic back at the release-2026-09-03_04-41-base commit and re-resolve Cargo.lock from main's. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates pocket-ic to
16.0.0, the published crates.io release, so the dependency comes from the registry rather than a dfinity/ic git pin andpackage.shfetches the server binary from the matching dfinity/pocketic release. No source changes were needed. See the commit message for details.Merging this PR will automatically tag
v16.0.0and trigger the release.🤖 Generated with Claude Code