feat: add bidirectional map/table selection sync and collapsible datatable [PR2]#3720
Draft
BRaimbault wants to merge 11 commits into
Draft
feat: add bidirectional map/table selection sync and collapsible datatable [PR2]#3720BRaimbault wants to merge 11 commits into
BRaimbault wants to merge 11 commits into
Conversation
Contributor
|
🚀 Deployed on https://pr-3720.maps.netlify.dhis2.org |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Part of DHIS2-21456
Description
Adds bidirectional highlighting/selection sync between the map and data table, persistent multi-feature selection, and a collapsible/resizable table panel. Second in the data table improvement series, building on PR1's toolbar and context menu.
Selection (DataTable)
selectionreducer, scoped per layer, and resets on layer switchMap ↔ table sync
@dhis2/ui's native greytr:hoverstyle while map-hover showed our own blue highlight)Filtering
Zoom actions
Table panel (BottomPanel)
Bug fixes
.includes()scans in selection filtering replaced with O(1)SetlookupsmapStateToPropswhen no context menu is openmaps-gl
Cluster.setVisibleIds()override: "show only selected" now re-clusters from the filtered feature set (viasource.setData()) instead of applying a GL filter expression, which can't target cluster circles (they carry no per-feature id). Applies to client- and donut-clustered event layers; server-clustered layers are unaffected since their data table is already unsupported today (unrelated pre-existing limitation)Layer#panToFeature()now accepts an array of ids, fitting the map to their combined boundsQuality checklist
Add N/A to items that are not applicable.
Screenshots
supporting images