Skip to content

chore: fix publint failure in release workflow - #62

Merged
achou11 merged 2 commits into
mainfrom
ac/fix-release-publint
Jul 27, 2026
Merged

chore: fix publint failure in release workflow#62
achou11 merged 2 commits into
mainfrom
ac/fix-release-publint

Conversation

@achou11

@achou11 achou11 commented Jul 22, 2026

Copy link
Copy Markdown
Member

Fixes an issue seen here where running publint during npm pack --dry-run fails on npm v12. The release action we use uses npm v12 and runs the dry run internally which is how this error surfaces.

There might be an fix in publint but it's currently not released (link).

I've opted for not running publint as part of the test scripts and instead having it be its own script that runs as a dedicated script in CI. Also no longer runs as part of the release workflow build command.

@achou11
achou11 requested a review from gmaclennan July 22, 2026 16:46
@socket-security

socket-security Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedpublint@​0.3.17 ⏵ 0.3.21100 +110081 +188 -1100

View full report

@achou11

achou11 commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

Maybe just opting to run publint as part of the build-command input in the release workflow might make more sense? I feel like I might be misunderstanding what --pack false actually does...

@gmaclennan gmaclennan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the postpack is needed? The CI check ensures we don't release with it broken. This is all we can do until publint fixes things.

@achou11

achou11 commented Jul 23, 2026

Copy link
Copy Markdown
Member Author

I don't think the postpack is needed? The CI check ensures we don't release with it broken. This is all we can do until publint fixes things.

Addressed via 7ba0103 (also updated PR description)

@achou11
achou11 requested a review from gmaclennan July 23, 2026 17:02
@achou11
achou11 merged commit a338304 into main Jul 27, 2026
12 checks passed
@achou11
achou11 deleted the ac/fix-release-publint branch July 27, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants