Repository navigation
Fix misspelled 'embedded' state key in reverse framing - #379
Merged
mielvds merged 3 commits intoNov 17, 2026
Merged
Conversation
Collaborator
|
Thanks @afeefaa333 ! Could you perhaps add a changelog entry? |
Contributor
Author
|
Done, added a changelog entry under 4.0.0 - unreleased / Fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #378
Framing with
{"@embed": "@never"}on a reverse property (inside an@reverseframe) was silently ignored, causing the matched node to befully embedded instead of referenced by
@idonly. Forward propertieswith the same flag worked correctly.
Root Cause
The reverse-framing branch set a state key as
'embeded'(typo) insteadof
'embedded'. The@nevercheck elsewhere readsstate['embedded'],so the flag set in the reverse branch was never actually read, causing
reverse-framed nodes to be treated as top-level nodes where
@neverdoesn't apply.
Fix
Corrected the key spelling from
'embeded'to'embedded'in thereverse-framing branch, matching the spelling used at the two existing
forward-framing call sites.
Testing
Added
test_frame_reverse_embed_never_is_respectedintest_frame.py,based on the reproduction case from the issue. Verified the test fails
on the unfixed code and passes with the fix.
make lintpasses.