Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated
Cookieheaders in an HTTP/2 or HTTP/3 request are currently comma-joined byWsgiToAsgi. Fortheme=lightandsession=abc, the WSGI app receivestheme=light,session=abc;SimpleCookieparses a single theme value and loses the session cookie.Join Cookie fields with
;, as required by the ASGI HTTP specification, so both cookies reach the WSGI application. Regression tests cover HTTP/2 and HTTP/3 and check both the header value and parsed cookies.Validation on Python 3.12.13: the two new cases fail before the fix; all 106 tests pass after it (1 existing xfail). All pre-commit checks pass. Three non-fatal multiprocessing deprecation warnings remain in the full suite.
Developed, reviewed, and tested with AI assistance (Codex).