Repository navigation
damage-control: rule groups (opt-out) and opt-in vendor packs (#1141) - #1142
Merged
Merged
Conversation
dotdevdotdev
force-pushed
the
dc-packs
branch
from
October 19, 2026 11:36
012c66b to
c33933f
Compare
Built by dotdev.dev
… docs (#1141) Built by dotdev.dev
Built by dotdev.dev
Migration enables all packs on an existing install; unparseable policy file read protectively and never written; gh repo delete -> git, npm unpublish + npm tooldef -> new default registry group; disabled-group grants reported as disabled, not typos. Built by dotdev.dev
Built by dotdev.dev
dotdevdotdev
force-pushed
the
dc-packs
branch
from
October 19, 2026 12:03
73b6781 to
f5f6fd2
Compare
…mbering, db binaries Built by dotdev.dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rule groups + opt-in vendor packs. Closes #1141
What it does
agentwire/safety/groups.py: every bundled rules/tooldefs file owned by exactly one group or pack (sweep test). Kernel (control-plane,core) always on; default groups (git,registry,agentwire,payloads,remote,mcp-tools,outbound) opt-out; packs (aws, gcp, firebase, cloud-hosting, databases, containers, infrastructure, publish) off until enabled.~/.agentwire/(packs:,disabled_groups:), comment-preserving writes.agentwire safety packs|groups list|status|enable|disable; mutations human-only (tty gate +PROTECTED_COMMAND_PATTERNS); MCPsafety_packs_list/safety_groups_listread-only.agentwire initstep, CLAUDE.md, agentwire role, skills, wiki. Agents suggest, never run.Review fixes
packs:absent, EVERY pack is enabled (not just those with files present); a fresh machine starts all-off. Test dropsdatabases.yaml+ bothawsfiles from an old layout and asserts both packs come back whole.read_statecatchesyaml.YAMLError; broken = most protective (everything on, nothing removed), never migrated or written over,enable|disablerefuse, doctor reports[!!] does not parse.gh repo delete->git.yaml(id nowgit.gh-repo-delete-deletes-repository);npm unpublish-> new defaultregistrygroup, which also owns thenpm.yamltooldef (npm publishask-tier) — previously that tooldef sat in thepublishpack. Sweep of the other packs: everything left is vendor-specific (cloud/infra deletes + deploys, docker/kubectl, DB CLIs and migration runners, non-npm publish). Migration runners (alembic/manage.py/rails/prisma/...) are the one judgement call; left indatabases.doctorandtasks reviewreport grants from a disabled group as "group 'git' disabled" (lint.split_missing_ids).Re-review fixes
tooldef.uv-run-...) are attributed to their owning tooldef file/group, so a disabled group reads as "group disabled", not a typo or[!!].uvis its own default group (opting out ofgitkeeps uv-run ask coverage).databasespack so doctor/init suggest it. Block-tierprisma migrate reset/flyway cleanstay in the pack: moving them would split the vendor-CLI boundary (dropdb/FLUSHALLsit beside them).Verification
gh repo delete/npm unpublishrules, disabled-group classification, plus earlier edited-file removal, kernel guard, tty gate, protected pattern.agentwire rebuild+safety install --yes.Built by dotdev.dev