LatencyPlugin never applies maxMs because the upper bound is exclusive #1927

Description

LatencyPlugin never applies the configured maxMs delay. The delay is computed as:

_random.Next(Configuration.MinMs, Configuration.MaxMs)

Random.Next(min, max) treats max as exclusive, so the largest possible delay is maxMs - 1. The schema describes maxMs as "The maximum amount of delay (in milliseconds) added to a request", which implies it's inclusive.

Code:

• dev-proxy/DevProxy.Plugins/Behavior/LatencyPlugin.cs

  Line 106 in d0965ec

  var delay = _random.Next(Configuration.MinMs, Configuration.MaxMs);

• dev-proxy/DevProxy.Plugins/Behavior/LatencyPlugin.cs

  Line 113 in d0965ec

  var delay = _random.Next(Configuration.MinMs, Configuration.MaxMs);

• dev-proxy/schemas/v3.2.0/latencyplugin.schema.json

  Lines 15 to 19 in d0965ec

  	"maxMs": {
  	"type": "integer",
  	"minimum": 0,
  	"description": "The maximum amount of delay (in milliseconds) added to a request. Default: 5000."
  	}

Expected behavior

The delay is chosen from the inclusive range minMs..maxMs, for example by using _random.Next(Configuration.MinMs, Configuration.MaxMs + 1).