Fix GC aspnet test machines#5234
Merged
Merged
Conversation
The aspnet-citrine-win/lin machines don't exist anymore, move to the aspnet-gold-win/lin instead.
Member
Author
|
cc: @VincentBu |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GC ASP.NET benchmark infrastructure/configuration to use the current ASP.NET benchmark machine profiles, replacing the retired aspnet-citrine-win/lin profiles with aspnet-gold-win/lin.
Changes:
- Switch crank
--profilevalues fromaspnet-citrine-win/lintoaspnet-gold-win/linacross base-suite and configuration CSVs. - Update docs/examples and the pre-run connectivity check to reference the
asp-gold-winhost andaspnet-gold-*profiles.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/benchmarks/gc/GC.Infrastructure/README.md | Updates override example to aspnet-gold-win (also contains a small grammar typo). |
| src/benchmarks/gc/GC.Infrastructure/GC.Infrastructure/Commands/RunCommand/BaseSuite/ASPNetBenchmarks.csv | Switches Windows benchmark commands to aspnet-gold-win. |
| src/benchmarks/gc/GC.Infrastructure/GC.Infrastructure/Commands/RunCommand/BaseSuite/ASPNetBenchmarks - All.csv | Switches Win/Linux commands to aspnet-gold-* (still has a duplicated FortunesEf_Linux row). |
| src/benchmarks/gc/GC.Infrastructure/GC.Infrastructure/Commands/ASPNetBenchmarks/AspNetBenchmarksCommand.cs | Updates ping target host to asp-gold-win. |
| src/benchmarks/gc/GC.Infrastructure/docs/ASPNETBenchmarks.md | Updates troubleshooting example endpoint to asp-gold-win. |
| src/benchmarks/gc/GC.Infrastructure/Configurations/GCPerfSim/SampleCrank.yaml | Updates sample crank command and machine list to include aspnet-gold-*. |
| src/benchmarks/gc/GC.Infrastructure/Configurations/ASPNetBenchmarks/ASPNetBenchmarks-Linux.csv | Switches Linux benchmark commands to aspnet-gold-lin. |
| src/benchmarks/gc/GC.Infrastructure/Configurations/ASPNetBenchmarks/ASPNetBenchmarks-All.csv | Switches Windows benchmark commands to aspnet-gold-win. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aspnet-citrine-win/lin machines don't exist anymore, move to the aspnet-gold-win/lin instead.
I've also removed couple of machines from the list that don't exist anymore.