fix(drizzle-kit): use DROP INDEX IF EXISTS for SQLite/Turso index drops#5565
Open
muhammadosama984 wants to merge 1 commit intodrizzle-team:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LibSQLModifyColumnemitDROP INDEX IF EXISTSwhen dropping indexes during Turso/libSQL alter-column/check-constraint flowsSqliteDropIndexConvertoremitDROP INDEX IF EXISTSfor explicit SQLite/Tursodrop_indexstatementsRoot Cause
LibSQLModifyColumn.convert()can run multiple times in a singledrizzle-kit pushexecution. It currently emits bareDROP INDEXstatements; repeated drops on the same index then fail withno such indexin SQLite/libSQL.SqliteDropIndexConvertor.convert()also emits bareDROP INDEX, which is non-idempotent.Fix
Use
DROP INDEX IF EXISTSin both paths so repeated drops become no-ops.Validation
pnpm --filter drizzle-kit exec vitest tests/libsql-statements.test.ts tests/push/libsql.test.ts tests/push/sqlite.test.ts --runCloses #5564