[Pg] Add order-by to pg integration tests to limit testing implementation defined behavior#5580
Open
Lukasdoe wants to merge 1 commit intodrizzle-team:mainfrom
Open
[Pg] Add order-by to pg integration tests to limit testing implementation defined behavior#5580Lukasdoe wants to merge 1 commit intodrizzle-team:mainfrom
Lukasdoe wants to merge 1 commit intodrizzle-team:mainfrom
Conversation
Lukasdoe
force-pushed
the
add-order-by-postgres
branch
3 times, most recently
from
0d79953 to
13d3b10
Compare
…defined behavior In the pg-common postgres integration tests, we had multiple test cases that relied on postgres output order which is not defined and may break in the future.
Lukasdoe
force-pushed
the
add-order-by-postgres
branch
from
13d3b10 to
d484db6
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not change the expected values, but future-proofs the tests in case the output order (which is not defined) may change with future releases.