fix(drizzle-kit): include ON DELETE/ON UPDATE in SQLite ALTER TABLE ADD COLUMN#5621
Open
JosephDoUrden wants to merge 1 commit intodrizzle-team:mainfrom
Open
fix(drizzle-kit): include ON DELETE/ON UPDATE in SQLite ALTER TABLE ADD COLUMN#5621JosephDoUrden wants to merge 1 commit intodrizzle-team:mainfrom
JosephDoUrden wants to merge 1 commit intodrizzle-team:mainfrom
Conversation
…DD COLUMN SQLiteAlterTableAddColumnConvertor.convert() was omitting ON DELETE and ON UPDATE clauses from REFERENCES in ALTER TABLE ADD COLUMN statements, even though SQLiteSquasher.unsquashFK() correctly parsed them. This caused generated migrations to produce invalid foreign key constraints that silently lost their referential actions. Fixes drizzle-team#5619
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
SQLiteAlterTableAddColumnConvertoromittingON DELETEandON UPDATEclauses fromREFERENCESinALTER TABLE ADD COLUMNstatements.Fixes #5619
Problem
When using
drizzle-kit generatewith SQLite, foreign key columns added viaALTER TABLE ADD COLUMNlost their referential actions:SQLiteSquasher.unsquashFK()correctly parsedonDelete/onUpdate, but thereferenceStatementtemplate inSQLiteAlterTableAddColumnConvertor.convert()only outputREFERENCES table(col)without the action clauses.Fix
Append
ON DELETEandON UPDATEclauses to thereferenceStatementwhen present, matching the pattern used bySQLiteCreateTableConvertor.Test plan
tests/test/sqlite.test.ts)tests/statements-combiner/libsql-statements-combiner.test.ts)