Issue #2842827: Offsite payment return fails on orders created from admin UI#601
Open
maciejzgadzaj wants to merge 1 commit intodrupalcommerce:8.x-2.xfrom
Open
Issue #2842827: Offsite payment return fails on orders created from admin UI#601maciejzgadzaj wants to merge 1 commit intodrupalcommerce:8.x-2.xfrom
maciejzgadzaj wants to merge 1 commit intodrupalcommerce:8.x-2.xfrom
Conversation
bojanz
force-pushed
the
8.x-2.x
branch
2 times, most recently
from
68e6e5f to
ac287b7
Compare
bojanz
force-pushed
the
8.x-2.x
branch
7 times, most recently
from
6be1d5c to
b8a7444
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Orders created from admin UI have
$order->checkout_flow = NULL. This causes a fatal error when trying to add a new offsite payment for them inOffsitePaymentController::returnCheckoutPage()when trying to load the$checkout_flow_plugin. Same thing applies toOffsitePaymentController::cancelCheckoutPage().See https://www.drupal.org/node/2842827