fix(conversion): isolate malformed groups and trust converter output (fixes #112) - #131
Draft
jakobtfaber wants to merge 1 commit into
Draft
fix(conversion): isolate malformed groups and trust converter output (fixes #112)#131jakobtfaber wants to merge 1 commit into
jakobtfaber wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes both conversion follow-ups reported in #112:
convertedandskippedgroup IDs returned byconvert_subband_groups_to_msinstead of reconstructing output names with a selector timestamp globskip_existing=Trueand the returned path existsRoot cause
convert_groupsparsed the two-minute conversion window before its per-grouptry, so malformed timestamps escaped the isolation contract. After conversion it searched for{selector_timestamp}*.ms, but the core converter derives its output group ID from a separate database query; small timestamp differences could therefore create an MS that the caller silently failed to return.Validation
PYTHONPATH=/data/dsa110-continuum /opt/miniforge/envs/casa6/bin/python -m pytest tests/test_calibrator_ms_generator.py -q— 26 passed/opt/miniforge/envs/casa6/bin/python -m ruff check dsa110_continuum/conversion/calibrator_ms_generator.py tests/test_calibrator_ms_generator.py— passedpython -m py_compile dsa110_continuum/conversion/calibrator_ms_generator.py— passedmake test-cloudimport-migration check passed, but the local run was interrupted aftercheck_contimg_mentions.pyremained blocked in an H17 filesystem request during repository-wide traversal; GitHub CI should run the same gate on the clean checkoutCloses #112.