Skip to content

Add CA bundle version and pinning status to user agent string#61

Merged
mihir-pradhan merged 1 commit into
mainfrom
ztcapin-484
Jul 20, 2026
Merged

Add CA bundle version and pinning status to user agent string#61
mihir-pradhan merged 1 commit into
mainfrom
ztcapin-484

Conversation

@mihir-pradhan

@mihir-pradhan mihir-pradhan commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Description

  • Added CA_BUNDLE_VERSION = "1.0" constant in Client.java
  • Modified Builder.build() to append ca_bundle/1.0 and (ca_pinning=enabled|disabled) to the user agent string based on the caPinningDisabled runtime state
  • The pinning status is derived from the same caPinningDisabled flag that configures TLS, so the reported value always matches the client's actual pinning state

How Has This Been Tested?

  • userAgent_includes_ca_bundle_version — verifies ca_bundle/1.0 is present in the user agent
  • userAgent_includes_ca_pinning_enabled — verifies (ca_pinning=enabled) when pinning is not disabled
  • userAgent_includes_ca_pinning_disabled — verifies (ca_pinning=disabled) when disableCaPinning() is called

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@mihir-pradhan
mihir-pradhan merged commit 8d84fec into main Jul 20, 2026
4 checks passed
@mihir-pradhan
mihir-pradhan deleted the ztcapin-484 branch July 20, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants