Separate signer policy and expose BLS signing fixtures - #3
Merged
Merged
Conversation
This was referenced Sep 12, 2026
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified.
Pull request overview
This PR separates signer policy checks into a public /policy entrypoint and exposes renamed BLS signing fixtures through the package surface.
Changes:
- Adds npm and JSR policy exports while removing the root policy export.
- Publishes BLS fixtures under
vectors/bls-signing/. - Updates generators, tests, package metadata, documentation, and changelog.
File summaries
| File | Reviewed change |
|---|---|
vectors/bls-signing/zero_seed_index_255.json |
Renamed BLS signing fixture. |
vectors/bls-signing/zero_seed_index_0.json |
Renamed BLS signing fixture. |
vectors/bls-signing/typed_data_digest_nested_struct.json |
Renamed BLS signing fixture. |
vectors/bls-signing/patterned_seed_index_1.json |
Renamed BLS signing fixture. |
vectors/bls-signing/anchor_zero_seed_index_42.json |
Renamed BLS signing fixture. |
tsconfig.json |
Includes the policy entrypoint. |
tools/rust-vector-emitter/check.mjs |
Checks the renamed corpus. |
src/typed-data/index.ts |
Removes the root policy export. |
src/policy/index.ts |
Exposes signer policy checks. |
src/package.test.ts |
Validates package-surface contracts. |
src/bls/vectors.generated.test.ts |
Tests fixtures from the renamed directory. |
scripts/generate-bls-vectors.ts |
Updates fixture generation paths. |
README.md |
Documents the migration and fixture paths. |
package.json |
Adds npm policy and fixture exports. |
jsr.json |
Adds the JSR policy export. |
CHANGELOG.md |
Documents the API and corpus changes. |
Review details
- Files reviewed: 10/16 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Move signer resource checks off the hashing entrypoint for npm and JSR. Expose the BLS V2 corpus through a public npm path and rename its directory without changing any frozen bytes. Keep the existing policy implementation and normative floor unchanged. Implements the package-surface cleanup proposed by ichbindas. Refs #2. Co-authored-by: ichbindas <54631150+ichbindas@users.noreply.github.com>
HDauven
force-pushed
the
fix/package-surface
branch
from
September 12, 2026 23:13
3add893 to
878fc95
Compare
HDauven
marked this pull request as ready for review
September 13, 2026 01:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement ichbindas's package-surface cleanup in #2 before the first registry publication.
checkPolicyLimitsthrough@dusk/typed-data/policyon npm and JSR, removing it from the root hashing export.@dusk/typed-data/vectors/bls-signing/*path, so consumers need not traverse the package's internal directories.vectors/bls-signing/and update its generator/test/native-check paths. All five BLS files are 100% identical renames; all 41 fixture files retain their original bytes.Hasher, BLS verifier and normative specification are unchanged. In particular, §11 still requires verifiers to support otherwise-valid inputs within the resource floor and permits refusal above it. Moving the helper clarifies its intended use; the 70,000-byte example is not itself a demonstrated verifier violation. The BLS scheme remains V2 and the typed-data protocol remains draft, not frozen.
Validation
/policy, absence from both hashing entrypoints, TypeScript declarations/negative controls, and resource-check behavior pass./policy, BLS exports and consumer policy/result types pass.Production E2E is Chrome-only and uses a fresh unfunded wallet with real provider/approval/engine/signing. This is not independent encoding/security certification or a full cross-platform Wallet audit. Local tarballs/workspaces do not prove registry availability.
Coordination
Connect #41 and Wallet #112 are updated together for this surface. Wallet's Noble pinning and checked little-endian golden-test serialization are kept in a separate Wallet hardening commit; no runtime dependency version was upgraded.
The package remains unpublished at
0.1.0-next.0(fresh npm/JSR probes return 404). Review/merge this library change, coordinate the actual registry version, then regenerate consumer lockfiles and repeat clean-install/normal CI checks. No registry publication, merge, release or protocol freeze is performed by this PR. Prior contributor history is preserved unchanged.Refs #2.