Repository navigation
Move check-functions into own R file, refactor longer checks into separate functions - #662
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
This PR moves internal check functions into R/checks.R, updates their callers, and reformats HTML printing.
Changes:
- Centralizes validation and warning helpers.
- Updates affected functions to use shared checks.
- Reformats
print_html().
File summaries
| File | Reviewed change |
|---|---|
R/utils.R |
Removes relocated helpers. |
R/print_html.R |
Reformats HTML printing and removes moved logic. |
R/get_marginaltrends.R |
Uses the extracted trend validator. |
R/get_marginalmeans.R |
Uses centralized checks. |
R/get_marginaleffects_type.R |
Uses the extracted prediction validator. |
R/get_marginalcontrasts.R |
Uses the shared filtering helper. |
R/get_inequalitycontrasts.R |
Removes the relocated helper. |
R/checks.R |
Adds centralized check helpers. |
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
All local checks pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.