Conversation
…consistent with compute_MVBS, and changed all hard-coded instances of range_sample to range_var
for more information, see https://pre-commit.ci
Collaborator
|
Hi @slonimer, just checking in to see if you know when you might have some time to work on this? I should have some time next week to review it! cheers! EDIT: i'm adding this to the next release, the V.012.0 at the end of the month! |
Author
|
It looks like there's a problem with the tests being outdated. I've been trying to trouble shoot it but running into problems. It seems like it's related to changes in how the xarray data is structured now versus how it was in the past |
…t with use of echo_range replacing range_samples
Collaborator
|
hey @slonimer, it seems the tests are going through now? is this ready for review? cheers! |
Author
|
@LOCEANlloydizard yes it is ready for review at your convenience, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to issue #1701
Updated to change optional input from range_label to range_var to be consistent with compute_MVBS, and changed all hard-coded instances of "range_sample" to range_var