Repository navigation
Maintenance: update dependencies and build tooling so the project runs on modern Node - #412
Open
eduardolundgren wants to merge 9 commits into
Open
eduardolundgren wants to merge 9 commits into
eduardolundgren wants to merge 9 commits into
Conversation
The gulp 3 toolchain no longer runs on modern Node (graceful-fs natives break on Node >= 12). The build is now a small script using terser for minification, producing the same build/ output as before (tracking.js, tracking-min.js and build/data). Bower is long dead, so its config is gone too; example dependencies (dat.gui, three) now come from npm devDependencies. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
nodeunit is unmaintained and fails to install on modern Node. The test files keep their nodeunit-style shape; a small compat runner adapts them to Node's built-in test runner, and the sandbox util now uses node:vm instead of nodeunit.utils.sandbox. Run with npm test; the timing-sensitive benchmark suite moved to npm run benchmark. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Mechanical cleanups so npm run lint passes: missing semicolons on function expressions, duplicate var declarations, curly braces on single-statement blocks, dot notation, strict equality on numeric comparisons, and removal of a dead rotation computation in Regressor.applyGlobalPrediction whose result was never used. The .jshintrc now allows == null checks (eqnull) and only flags unused variables, not unused parameters documented in public signatures. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The examples loaded three.js r67 from a sibling bower directory that no longer exists. They now load three 0.147.0 (the last version to ship a UMD build) from node_modules, and the renderers were ported off APIs removed years ago: ImageUtils.loadTextureCube is replaced by CubeTextureLoader, the ShaderLib cube skybox hack by scene.background, and CanvasRenderer/SpriteCanvasMaterial by WebGLRenderer/SpriteMaterial with a canvas-generated circle texture. FishTankRenderer also resizes with the window now instead of sizing once at load. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
CI runs lint, build and the unit tests on Node 18/20/22. The README drops the dead Travis and David badges and bower instructions, and documents the npm scripts for building, testing and serving the examples. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Image.blur returned the raw Float32Array from the separable convolution, but Image.grayscale (since its buffer-based perf rewrite) reinterprets its input buffer as 8-bit RGBA. Feeding it float data made it read float bit patterns as pixels, which produced thousands of phantom FAST corners and garbage BRIEF matches in the feature matching examples. Blur now converts the convolution result back to a Uint8ClampedArray. Adds a regression test covering the blur-into- grayscale pipeline. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
这是来自QQ邮箱的假期自动回复邮件。
您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。
|
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an AI-assisted maintenance pass to get the project back into a workable state on modern Node — no new features, no API changes.
What changed
npm run build). Thebuild/output layout is unchanged.npm test, Node >= 18). The timing-based benchmark suite moved tonpm run benchmark.npm run lint(jshint) passes again; mechanical fixes only (semicolons, duplicate declarations, strict equality on numeric comparisons).npm startserves the repo locally for trying the examples.Image.blurreturned float data thatImage.grayscale(since its buffer-based rewrite) misread as 8-bit RGBA, producing thousands of phantom FAST corners in the BRIEF feature-matching examples. Blur now returnsUint8ClampedArray; a regression test covers the pipeline.All examples were manually verified in the browser (camera demos up to the permission prompt).
🤖 Generated with Claude Code