Skip to content

ci: set check-latest on floating setup-node versions - #916

Merged
MarshallOfSound merged 1 commit into
mainfrom
ci/node-check-latest
Oct 22, 2026
Merged

MarshallOfSound merged 1 commit into
mainfrom
ci/node-check-latest

Conversation

@claude

@claude claude Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Requested by Samuel Attard · Slack thread

The setup-node steps here ask for a floating Node version (lts/-1), which setup-node satisfies from the runner's tool cache before checking for anything newer, so CI can keep running an older patch after a Node security release. Setting check-latest makes it resolve the newest matching release and only download when the cached copy is stale.


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MM6DBDZdmumVSaiGNt2vF7
@claude
claude Bot requested review from a team and ckerr as code owners October 21, 2026 23:05

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR and didn't find any bugs. The repo's CODEOWNERS file covers every path, though, so a code owner still has to sign off on it.

What was reviewed:

  • All four actions/setup-node steps (check-sdk-version.yml, lint.yml with two jobs, test.yml) now set check-latest: true next to node-version: lts/-1. No setup-node step was missed.
  • The action SHA pins, the # tag: comments and the actions/cache steps are unchanged. The YAML indentation matches each file.
Extended reasoning...

The change adds one line, check-latest: true, to each of the four setup-node steps in three CI workflow files, four lines in total. It doesn't touch application code, secrets, permissions or action pins. The only behavior change is that CI resolves the newest lts/-1 release from the network instead of using the runner's cached version. The change is trivial, but I didn't approve because the root CODEOWNERS file assigns every path (*) to code owners.

@MarshallOfSound
MarshallOfSound merged commit 5ad1d82 into main Oct 22, 2026
14 checks passed
@MarshallOfSound
MarshallOfSound deleted the ci/node-check-latest branch October 22, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants