Repository navigation
fix: run remote generators with Chromium's bundled python - #922
Merged
MarshallOfSound merged 2 commits intoOct 23, 2026
Merged
Conversation
nornagon
changed the title
The mojom, Blink, grit and TypeScript/WebUI generator steps were forced to run as plain `python3` on the remote worker. That only works if the worker image has python3 installed; otherwise they fail with "python3: not found". This matched Chromium's own rules when it was added. Chromium has since switched them to the Linux python3 it ships in third_party/cpython3 (crrev.com/c/8160801) and adds that interpreter to each rule's inputs, so it was already being uploaded and then ignored. Stop overriding remote_command so it gets used. Branches from before that change are unaffected, because their rules already say `python3`.
Chromium's two grit rules set no timeout, so siso requests a 2 hour action timeout for them. A backend with a lower limit rejects the action outright instead of running it. Default the remote generator rules to 10 minutes. The other eight rules already set 2 minutes and keep it.
ckerr
approved these changes
Oct 23, 2026
nornagon
force-pushed
the
fix/remote-generator-python
branch
from
October 23, 2026 17:43
4e4f763 to
8f4e249
Compare
Contributor
Author
|
@ckerr commits are signed now! |
MarshallOfSound
approved these changes
Oct 23, 2026
MarshallOfSound
enabled auto-merge (squash)
October 23, 2026 18:07
MarshallOfSound
disabled auto-merge
October 23, 2026 18:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#889 sets
remote_command = "python3"on the remote generator rules, which only works if the worker image has python3 installed.Chromium's rules no longer need that. Since crrev.com/c/8160801 they run the Linux python3 from
third_party/cpython3and add it to their inputs, so we've been uploading it and then ignoring it. This drops the override.python3.Also gives the two grit rules a 10 minute timeout. They set none, so siso asks for 2 hours, which backends with a lower cap reject.
Tested on a Linux host against a backend whose workers have no python3: all 2,113 generator steps in
electronran remotely, with output identical to a local build.Not tested on Electron's RBE or from macOS/Windows hosts.
The generator steps' action digests change, so expect cache misses for them on the first build after merging.