Skip to content

[Speech Engine] Add disable_auth parameter - #806

Merged
PaulAsjes merged 4 commits into
mainfrom
pma/speech-engine-disable-auth
Jul 1, 2026
Merged

[Speech Engine] Add disable_auth parameter#806
PaulAsjes merged 4 commits into
mainfrom
pma/speech-engine-disable-auth

Conversation

@PaulAsjes

@PaulAsjes PaulAsjes commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Adds new disable_auth parameter.


Note

High Risk
Opt-out JWT verification on the Speech Engine WebSocket entrypoint is security-sensitive; misuse exposes sessions to unauthenticated clients and downstream LLM/compute abuse, though the flag defaults off and is documented as insecure.

Overview
Adds an opt-in disable_auth flag on SpeechEngineServer and SpeechEngineResource.serve() so deployments behind an ElevenLabs IP allowlist can skip JWT checks on X-Elevenlabs-Speech-Engine-Authorization. With auth disabled, an API key is no longer required at startup, the handshake bypasses verification, and a UserWarning is emitted; default behavior still rejects missing or invalid JWTs with 401.

The standalone server now uses websockets.asyncio.server.serve (dependency bumped to websockets>=13.0) so the process_request hook matches the asyncio (connection, request) / connection.respond() API. Release 2.56.0 and README Authentication docs accompany the change, plus integration tests for disabled auth, warnings, and enforced auth paths.

Reviewed by Cursor Bugbot for commit a47165e. Bugbot is set up for automated code reviews on this repo. Configure here.

@PaulAsjes
PaulAsjes requested a review from anitej-11 July 1, 2026 14:03

@anitej-11 anitej-11 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@PaulAsjes
PaulAsjes merged commit 1b45413 into main Jul 1, 2026
5 checks passed
@PaulAsjes
PaulAsjes deleted the pma/speech-engine-disable-auth branch July 1, 2026 14:50
@fern-api fern-api Bot mentioned this pull request Jul 7, 2026
kraenhansen pushed a commit that referenced this pull request Jul 7, 2026
* [fern-generated] Update SDK

Generated by Fern
CLI Version: unknown
Generators:
  - fernapi/fern-python-sdk: 4.42.0

* [fern-replay] Applied customizations

Patches with unresolved conflicts (1):
  - patch-1b45413e: [Speech Engine] Add disable_auth parameter (#806)
    Run `fern-replay resolve` to apply these customizations.

---------

Co-authored-by: fern-api <115122769+fern-api[bot]@users.noreply.github.com>
@fern-api fern-api Bot mentioned this pull request Jul 9, 2026
kraenhansen pushed a commit that referenced this pull request Jul 9, 2026
* [fern-generated] Update SDK

Generated by Fern
CLI Version: unknown
Generators:
  - fernapi/fern-python-sdk: 4.42.0

* [fern-replay] Applied customizations

Patches with unresolved conflicts (1):
  - patch-1b45413e: [Speech Engine] Add disable_auth parameter (#806)
    Run `fern-replay resolve` to apply these customizations.

---------

Co-authored-by: fern-api[bot] <115122769+fern-api[bot]@users.noreply.github.com>
@fern-api fern-api Bot mentioned this pull request Jul 13, 2026
PaulAsjes pushed a commit that referenced this pull request Jul 13, 2026
* [fern-generated] Update SDK

Generated by Fern
CLI Version: unknown
Generators:
  - fernapi/fern-python-sdk: 4.42.0

* [fern-replay] Applied customizations

Patches with unresolved conflicts (1):
  - patch-1b45413e: [Speech Engine] Add disable_auth parameter (#806)
    Run `fern-replay resolve` to apply these customizations.

---------

Co-authored-by: fern-api[bot] <115122769+fern-api[bot]@users.noreply.github.com>
This was referenced Jul 21, 2026
PaulAsjes added a commit that referenced this pull request Jul 22, 2026
* [fern-generated] Update SDK

Generated by Fern
CLI Version: unknown
Generators:
  - fernapi/fern-python-sdk: 4.64.1

* [fern-replay] Applied customizations

Patches with unresolved conflicts (1):
  - patch-1b45413e: [Speech Engine] Add disable_auth parameter (#806)
    Run `fern-replay resolve` to apply these customizations.

* Use scribe_v2

---------

Co-authored-by: fern-api[bot] <115122769+fern-api[bot]@users.noreply.github.com>
Co-authored-by: Paul Asjes <paul.asjes@elevenlabs.io>
@fern-api fern-api Bot mentioned this pull request Jul 30, 2026
kraenhansen pushed a commit that referenced this pull request Jul 30, 2026
* [fern-generated] Update SDK

Generated by Fern
CLI Version: unknown
Generators:
  - fernapi/fern-python-sdk: 4.64.1

* [fern-replay] Applied customizations

Patches applied (1):
  - patch-560b8934: fix: send list-of-primitive multipart fields as repeated form fields (#819) (#825)

Patches with unresolved conflicts (1):
  - patch-1b45413e: [Speech Engine] Add disable_auth parameter (#806)
    Run `fern-replay resolve` to apply these customizations.

---------

Co-authored-by: fern-api[bot] <115122769+fern-api[bot]@users.noreply.github.com>
kraenhansen added a commit that referenced this pull request Jul 30, 2026
…#828)

patch-1b45413e was captured from "[Speech Engine] Add disable_auth
parameter (#806)", but its remaining diff is only a hardcoded version
bump (2.55.0 to 2.56.0) plus websockets >=13.0 (now native via the
generator config). Because it pins an old version string, it collided
with the version line on every regeneration and surfaced as an
unresolved conflict (most recently in the v2.60.0 regen PR #826).

Running `fern replay forget patch-1b45413e` drops it from the active
patch set and tombstones its content hash so it is not re-captured.
The #825 multipart fix (patch-560b8934) is unaffected, and disable_auth
itself is generated from the spec and does not depend on this patch.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants