[codex] add Apple OAuth provider#281
Merged
Merged
Conversation
|
|
||
| csrfTokens, ok := hostedOAuthCSRFTokens(r, provider) | ||
| if !ok { | ||
| h.logger.Info("hosted_oauth_csrf_cookie_invalid", zap.String("provider", provider)) |
49ed0fb to
36c4b40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Sign in with Apple alongside Google, Microsoft, and GitHub, including typed OAuth exchange parameters, Apple ID-token verification, provider registration, generated API updates, and operator documentation.
Security and behavior
Adds hosted OAuth callbacks with PKCE, signed state, bounded per-provider
__Host-CSRF token sets, Appleform_posthandling, and exact-origin/path return URL validation. Concurrent hosted sign-ins now complete independently.Impact
Operators can configure Apple OAuth with the documented
GATEWAY_OAUTH_APPLE_*variables. Browser clients can use the hosted flow or forward Apple's application-owned POST callback into the headless API.Validation
go test ./pkg/oauth ./internal/app ./internal/config ./internal/connect ./internal/service ./internal/observabilitygo test -tags=integration ./tests/integration -run '^$'npm run buildindocs-sitegit diff --checkandgofmt -l