correct repository docs#6
Conversation
Remove stale rate-limiter template text and align README endpoints with docker-compose. Document that audit export is not implemented instead of advertising it as shipped behavior.
|
All committers have signed the CLA; thanks. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d6bdc6c2bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // failClosedRateLimiter does not call a real rate-limiter; if a key carries | ||
| // limit_refs, verify is denied. Keys without limit_refs are unaffected. |
There was a problem hiding this comment.
Delete the behavior-restating rate-limiter comment
AGENTS.md says comments are for the why and specifically forbids comments that restate what the code does. This updated comment only repeats that the fail-closed limiter denies keys with limit_refs while leaving other keys unaffected, which is already visible from the implementation and VerifyKey flow. Remove it or replace it with the non-obvious rationale for why this binary ships a fail-closed limiter.
Useful? React with 👍 / 👎.
Summary
Tests