Align release coverage gates with CI#67
Merged
Merged
Conversation
The release workflow gated internal/ >= 84% and pkg/ >= 88%, but CI (the bar every PR passes) gates internal/ >= 68% and pkg/ >= 65%, and measured internal/ coverage is 78.73%. The stricter release thresholds were never exercised (no release had been cut) and are unmeetable, so the first v0.1.0 release failed at the coverage gate. Align release.yml to the CI/.coverage-gates.yml standard; the maintained per-package floors are unchanged and still enforced in both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.1.0 release failed because release.yml gated
internal/ >= 84%/pkg/ >= 88%, while CI (the bar every PR passes) gatesinternal/ >= 68%/pkg/ >= 65%and measuredinternal/coverage is 78.73%. Those release thresholds were never exercised (no release had ever run) and are unmeetable. Align release.yml to the CI standard; the maintained per-package floors (.coverage-gates.yml) are unchanged and still enforced identically in both workflows.