add heatpump pool on/off, pool active, MP100 shunt setpoint and pool … - #3252
Merged
Merged
Conversation
…pump Tested with a heatpump (0x08) and MP100 pool module (0x11), custom entities compared against RC300 operation and a power meter on the circulation pump. - boiler `poolon` (0x48A offset 0), writable, RC300 writes 01/00 - boiler `hppoolon` (0x488 offset 0 bit 6), pool heating actually active - pool `poolshuntset` (0x5C4 offset 0, heatpump -> MP100), shunt setpoint; `poolshunt` follows within ~2 min - pool `poolpump` (0x5BA offset 4), 0 = running, 2 = off. This byte is only in MP100 -> heatpump telegrams, so the pool module now also handles telegrams it sends to other devices - simulator: `test pool` Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013YrkDbvxEv3ZMS7SPSKCGd
Contributor
|
that's really impressive, how you navigated the code and covered all the basis. @MichaelDvP anything you see missed here? |
Contributor
|
Looks good. Maybe add in the translations a |
- block comment `// mixer pool` -> `// MP100 pool module`, hydrTemp moved to `// water` - `poolpump` -> `poolrequest` (pool request, MP100 input contacts) - shorter en/de texts: pool setpoint / Pool Soll, valve status / Ventil Status, valve actual / Ventil Ist, valve setpoint / Ventil Soll - existing short names (poolsettemp, pooltemp, poolshuntstatus, poolshunt) unchanged Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013YrkDbvxEv3ZMS7SPSKCGd
shorten
Contributor
Author
|
Contributor
Author
|
3.9.0-dev.15 Thanks for the fast implementation. 
|
Contributor
|
thank you for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…pump
Tested with a Buderus Logatherm WSW196i.2-6 [heatpump (0x08)] and MP100 [pool module (0x11)], custom entities compared against RC300 operation and a power meter on the circulation pump.
poolon(0x48A offset 0), writable, RC300 writes 01/00hppoolon(0x488 offset 0 bit 6), pool heating actually activepoolshuntset(0x5C4 offset 0, heatpump -> MP100), shunt setpoint;poolshuntfollows within ~2 minpoolpump(0x5BA offset 4), 0 = running, 2 = off. This byte is only in MP100 -> heatpump telegrams, so the pool module now also handles telegrams it sends to other devices