NXT-15800: Removed react-is override dependency#865
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #865 +/- ##
========================================
Coverage 85.06% 85.06%
========================================
Files 118 118
Lines 4493 4493
Branches 1226 1225 -1
========================================
Hits 3822 3822
Misses 518 518
Partials 153 153 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| - name: Clone and setup Enact CLI | ||
| run: | | ||
| git clone --branch=develop --depth 1 https://github.com/enactjs/cli ../cli | ||
| git clone --branch=feature/NXT-15800 --depth 1 https://github.com/enactjs/cli ../cli |
Contributor
There was a problem hiding this comment.
this should be reverted ?
ion-andrusciac-lgp
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Removed react-is override dependency from agate as it is handled in enact/cli
Resolution
Removed react-is dependency from agate sampler as storybook does not use enact cli
Additional Considerations
temmporary set feature branch of cli
Links
NXT-15800
Comments
Enact-DCO-1.0-Signed-off-by: Daniel Stoian (daniel.stoian@lgepartner.com)