Skip to content

NXT-15224: Updated Card to the latest GUI#372

Merged
alexandrumorariu merged 19 commits into
developfrom
feature/NXT-15224
Jun 19, 2026
Merged

NXT-15224: Updated Card to the latest GUI#372
alexandrumorariu merged 19 commits into
developfrom
feature/NXT-15224

Conversation

@ion-andrusciac-lgp

@ion-andrusciac-lgp ion-andrusciac-lgp commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Updated Card to the latest GUI

Resolution

  • Icons can be placed as a prefix for labels
  • Badges now natively support Icon, Image, or Text sub-components.
  • Title and ImageIcon can be centered using centeredTitle alongside captionOverlay or captionOverlayOnFocus
  • ProgressBar or MediaDuration badge can be overlaid inside the card component using progressBarOverlay or durationOverlay
  • Captions can now overflow their container using captionOverflow or captionOverflowOnFocus

Additional Considerations

Links

NXT-15224

Comments

Enact-DCO-1.0-Signed-off-by: Ion Andrusciac ion.andrusciac@lgepartner.com

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.40506% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.54%. Comparing base (4378483) to head (0f0be4d).

Files with missing lines Patch % Lines
Card/Card.js 92.40% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #372      +/-   ##
===========================================
+ Coverage    82.46%   82.54%   +0.07%     
===========================================
  Files          153      153              
  Lines         7523     7579      +56     
  Branches      2270     2298      +28     
===========================================
+ Hits          6204     6256      +52     
- Misses        1026     1029       +3     
- Partials       293      294       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ion-andrusciac-lgp ion-andrusciac-lgp changed the title NXT-15224: Updated `Card to the latest GUI NXT-15224: Updated Card to the latest GUI Jun 16, 2026
@ion-andrusciac-lgp ion-andrusciac-lgp marked this pull request as ready for review June 16, 2026 17:36
Comment thread Card/tests/Card-specs.js
Comment thread Card/Card.js Outdated
Comment thread Card/Card.js Outdated
Comment thread Card/Card.js Outdated
Comment thread Card/Card.js
Comment thread Card/Card.js Outdated
Comment thread samples/sampler/stories/default/Card.js Outdated
@daniel-stoian-lgp

daniel-stoian-lgp commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

is this intended? showDuration && durationOverlay false/ true. More exactly, the left image position changes
image
vs
image

Comment thread samples/sampler/stories/default/Card.js Outdated
Comment thread samples/sampler/stories/default/Card.js Outdated
Comment thread styles/variables.less

@daniel-stoian-lgp daniel-stoian-lgp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only a few comments. great job

@ion-andrusciac-lgp

ion-andrusciac-lgp commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

is this intended? showDuration && durationOverlay false/ true. More exactly, the left image position changes image vs image

As long as we do not have a specific design for that case, this is intended. The same behavior we can observe on showProgressBar true/false.

@daniel-stoian-lgp daniel-stoian-lgp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrumorariu alexandrumorariu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrumorariu alexandrumorariu merged commit e90fa49 into develop Jun 19, 2026
6 checks passed
@alexandrumorariu alexandrumorariu deleted the feature/NXT-15224 branch June 19, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants