Skip to content

NXT-12130: Update tooltip with new features#383

Open
alexandrumorariu wants to merge 17 commits into
developfrom
feature/NXT-12130-1
Open

NXT-12130: Update tooltip with new features#383
alexandrumorariu wants to merge 17 commits into
developfrom
feature/NXT-12130-1

Conversation

@alexandrumorariu

Copy link
Copy Markdown
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

I updated Tooltip to support the following:
Image - added via prop tooltipImage
Image size - added via prop tooltipImageSize
No Arrow - added via prop noArrow
Add css to label - added via prop tooltipCss

Resolution

Additional Considerations

Links

NXT-12130

Comments

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.63%. Comparing base (4378483) to head (d4e5537).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #383      +/-   ##
===========================================
+ Coverage    82.46%   82.63%   +0.16%     
===========================================
  Files          153      153              
  Lines         7523     7647     +124     
  Branches      2270     2334      +64     
===========================================
+ Hits          6204     6319     +115     
- Misses        1026     1034       +8     
- Partials       293      294       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dan-ichim-lgp dan-ichim-lgp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things before merge:

multi: !marquee looks like a regression — previously wrapping only applied when width was set; please narrow this (e.g. !!width || !!tooltipImage).
tooltipImageSize uses raw px while width uses scaleToRem — image sizing may be wrong on TV resolutions.
Also worth adding unit tests for the new props and clarifying how this relates to the ContextualPopupDecorator ticket scope, since this branch only touches Tooltip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants