NXT-12130: Update tooltip with new features#383
Open
alexandrumorariu wants to merge 17 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #383 +/- ##
===========================================
+ Coverage 82.46% 82.63% +0.16%
===========================================
Files 153 153
Lines 7523 7647 +124
Branches 2270 2334 +64
===========================================
+ Hits 6204 6319 +115
- Misses 1026 1034 +8
- Partials 293 294 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dan-ichim-lgp
left a comment
Contributor
There was a problem hiding this comment.
Two things before merge:
multi: !marquee looks like a regression — previously wrapping only applied when width was set; please narrow this (e.g. !!width || !!tooltipImage).
tooltipImageSize uses raw px while width uses scaleToRem — image sizing may be wrong on TV resolutions.
Also worth adding unit tests for the new props and clarifying how this relates to the ContextualPopupDecorator ticket scope, since this branch only touches Tooltip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
I updated Tooltip to support the following:
Image - added via prop
tooltipImageImage size - added via prop
tooltipImageSizeNo Arrow - added via prop
noArrowAdd css to label - added via prop
tooltipCssResolution
Additional Considerations
Links
NXT-12130
Comments