Rename inMemoryStore to indexerState for clarity - #1331
Merged
Conversation
The binding carries IndexerState.t — the whole indexer state, not just a store — so the inMemoryStore name misled readers. Rename the parameter, contextParams field, and local bindings across EventProcessing, UserContext, LoadLayer, and BatchProcessing (and the affected tests). The InMemoryStore module and the in-memory-store concept are unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01736gwmXs4qXZ1ujzF1C8nk
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughRenames the parameter ChangesinMemoryStore → indexerState rename
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
DZakh
enabled auto-merge (squash)
June 17, 2026 10:18
DZakh
disabled auto-merge
June 17, 2026 10:18
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the
inMemoryStoreparameter and variable throughout the codebase toindexerStateto better reflect its actual purpose and scope.Summary
This refactoring improves naming clarity by renaming
inMemoryStoretoindexerStateacross the event processing pipeline. TheIndexerStatetype manages more than just in-memory storage—it coordinates the entire indexer state including load managers, persistence, and checkpoint tracking. The new name better communicates this broader responsibility.Changes
Renamed parameter
~inMemoryStoreto~indexerStatein:LoadLayer.loadById,LoadLayer.loadByFilter,LoadLayer.loadEffectEventProcessing.runEventHandlerOrThrow,EventProcessing.runHandlerOrThrow,EventProcessing.preloadBatchOrThrow,EventProcessing.runBatchHandlersOrThrow,EventProcessing.processEventBatchUserContext.contextParamstype and related handler context functionsBatchProcessing.processNextBatchMockIndexer.InMemoryStoreUpdated all call sites and variable bindings to use the new name
Updated a comment in
LoadLayer.resfrom "inMemoryStore" to "in-memory store" for consistencyUpdated a comment in
BatchProcessing.resfrom "inMemoryStore.isProcessing" to "state.isProcessing"Implementation Details
This is a pure rename with no functional changes. All references to the parameter have been updated consistently across the codebase, including test files and interface definitions (
.resifiles).https://claude.ai/code/session_01736gwmXs4qXZ1ujzF1C8nk
Summary by CodeRabbit