Skip to content

fix: tests expect task response#261

Merged
equinor-ruaj merged 1 commit intomainfrom
fix/tests-expect-task-response
Apr 30, 2026
Merged

fix: tests expect task response#261
equinor-ruaj merged 1 commit intomainfrom
fix/tests-expect-task-response

Conversation

@equinor-ruaj
Copy link
Copy Markdown
Contributor

@equinor-ruaj equinor-ruaj commented Apr 30, 2026

Issue

Closes #262

Description

Sumo-core was updated to handle case deletes as a Task: https://github.com/equinor/sumo-core/pull/994
Update the tests to expect the new response.

  • Do not try to convert to json
  • Assert response text is "Accepted."

How to test

Run the two tests that were failing test_upload_duplicate_ensemble and test_upload_search_delete_ensemble_child and see that they pass.

(The tests are also run as part of the PR checks here)

Checklist

  • No redundant `print()` statements, commented-out code, or other remnants from the development 👀
  • New/refactored code is following same conventions as the rest of the code base 🧬
  • New/refactored code is tested ⚙
  • Documentation has been updated 🧾
  • Commits are semantic ✅

@equinor-ruaj equinor-ruaj requested a review from a team April 30, 2026 07:45
@equinor-ruaj equinor-ruaj merged commit cfd9c41 into main Apr 30, 2026
11 checks passed
@equinor-ruaj equinor-ruaj deleted the fix/tests-expect-task-response branch April 30, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests are failing after Sumo-core handles case deletes as Task

2 participants