Skip to content

feat(display_drivers): Update display drivers to share code by refactoring into base class. Add SpiPanelIo helper class as well#620

Open
finger563 wants to merge 3 commits into
mainfrom
feat/display-drivers-refactor
Open

feat(display_drivers): Update display drivers to share code by refactoring into base class. Add SpiPanelIo helper class as well#620
finger563 wants to merge 3 commits into
mainfrom
feat/display-drivers-refactor

Conversation

@finger563
Copy link
Copy Markdown
Contributor

@finger563 finger563 commented May 28, 2026

Description

Motivation and Context

How has this been tested?

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

Hardware

  • I have updated the design files (schematic, board, libraries).
  • I have attached the PDFs of the SCH / BRD to this PR
  • I have updated the design output (GERBER, BOM) files.

…oring into base class. Add SpiPanelIo helper class as well
Copilot AI review requested due to automatic review settings May 28, 2026 04:15
@finger563 finger563 self-assigned this May 28, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions
Copy link
Copy Markdown

⚡ Static analysis result ⚡

🔴 cppcheck found 2 issues! Click here to see details.

if (!spi_bus || !spi_bus->initialized()) {
fmt::print("Failed to initialize SPI bus\n");
return;
}
#ifdef CONFIG_DISPLAY_QUAD_SPI

!Line: 426 - style: Condition '!spi_bus' is always false [knownConditionTrueFalse]

if (!panel_io || !panel_io->initialized()) {
fmt::print("Failed to initialize SPI panel I/O\n");
return;
}
#endif

!Line: 472 - style: Condition '!panel_io' is always false [knownConditionTrueFalse]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants