Conversation
This was referenced Sep 11, 2026
Author
|
Implements / tracks feature request: #19072 Related Async issue: ESP32Async/ESPAsyncWebServer#475 |
This was referenced Sep 11, 2026
EyJunge1
force-pushed
the
feat/http-query-rfc-10008
branch
from
September 12, 2026 19:21
3407031 to
fdebf4d
Compare
Ashish285
reviewed
Sep 15, 2026
Ashish285
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for raising this PR and adding in the support, I only have some minor comments
EyJunge1
force-pushed
the
feat/http-query-rfc-10008
branch
from
September 15, 2026 05:54
3cee831 to
1c9f9ac
Compare
Ashish285
reviewed
Sep 23, 2026
Register QUERY in HTTP_METHOD_MAP and accept a leading 'Q' in the request-line matcher so esp_http_server can parse safe, idempotent queries with a body. Document HTTP_QUERY on the server API and cover a bodied QUERY request in the esp_http_server test app.
EyJunge1
force-pushed
the
feat/http-query-rfc-10008
branch
from
September 23, 2026 07:33
4d3f24f to
4fb3dd1
Compare
Collaborator
|
LGTM! |
Collaborator
|
sha=4fb3dd1afce5bb705828e88b8bb41f52e44cb2e0 |
AdityaHPatwardhan
approved these changes
Sep 24, 2026
Ashish285
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the RFC 10008
QUERYmethod to the vendoredhttp_parsersoesp_http_server(and Arduino-ESP32WebServer, which uses this enum) can accept safe, idempotent requests that carry a body.HTTP_METHOD_MAP:XX(33, QUERY, QUERY)(HTTP_QUERY)Q→HTTP_QUERY; remaining characters come frommethod_strings[]HTTP_PARSER_HAS_QUERY: feature macro for downstream (the enumerator is not a#define)This does not change
esp_http_serverURI registration beyond makingHTTP_QUERYa validhttpd_method_t. Callers can then register.method = HTTP_QUERY.Feature issue: #19072
Related:
Test
QUERY /path HTTP/1.1+Content-Lengthparses asHTTP_QUERY(notHPE_INVALID_METHOD/ 400)http_method_str(HTTP_QUERY)returns"QUERY"HTTP_PARSER_HAS_QUERYis definedNote
Low Risk
Adds a new recognized HTTP method in the parser and documents registration; existing methods and error handling paths are unchanged aside from
QUERYno longer mapping to invalid/501.Overview
Adds RFC 10008
HTTP_QUERYto the vendoredhttp_parser, soesp_http_servercan register and serveQUERYrequests instead of treating them as unknown methods (501).The parser gains
HTTP_QUERYinHTTP_METHOD_MAPand request-line dispatch for a leadingQ, which completes against the"QUERY"method string like other methods. English and Chinese HTTP server docs now mentionHTTP_QUERYand that it may carry a request body when registered with.method = HTTP_QUERY.An
esp_http_serverintegration test sendsQUERY /searchwithContent-Lengthand JSON body, checkshttp_method_str(HTTP_QUERY), handler dispatch, body echo, and HTTP 200. Minor comment typo fixes inhttp_parser.care included.Reviewed by Cursor Bugbot for commit 4fb3dd1. Bugbot is set up for automated code reviews on this repo. Configure here.